On Tue, May 27, 2014 at 5:10 PM, Barry Song <Barry.Song@xxxxxxx> wrote: >>> after moving pinctrl name from sirfsoc-gpio* to dev_name(&pdev->dev) as below: >>> - err = gpiochip_add_pin_range(&sgpio->chip.gc, "sirfsoc-gpio*", >>> + err = gpiochip_add_pin_range(&sgpio->chip.gc, dev_name(&pdev->dev), >>> >>> Acked-by: Barry Song <Baohua.Song@xxxxxxx> > >>Does this mean it works with that change so it's a Tested-by? > > yes. with the above change. OK applied to devel with that change, THANKS Barry, I really like the looks of the driver better after this change. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html