Re: [PATCH] gpio: Add run-time dependencies to R-Car driver

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Fri, May 23, 2014 at 1:42 PM, Jean Delvare <jdelvare@xxxxxxx> wrote:

> The Renesas R-Car GPIO driver is only useful on shmobile unless build
> testing.
>
> Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>
> Cc: Magnus Damm <damm@xxxxxxxxxxxxx>
> Cc: Simon Horman <horms+renesas@xxxxxxxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: Alexandre Courbot <gnurou@xxxxxxxxx>

Patch applied with Simon's ACK.

> Simon, is it correct? I couldn't remove the dependency on ARM because
> the driver uses set_irq_flags which is arm-specific.

We usually #ifdef CONFIG_ARM around that function call actually.

But now, we also do that in the core gpiolib irqchip helpers, so just
switch this driver to use the irqchip helpers and you can drop the ARM
dependency.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html