Re: [PATCH] gpio: Add run-time dependencies to R-Car driver

[Simon Horman <horms@xxxxxxxxxxxx>]

On Fri, May 23, 2014 at 01:42:14PM +0200, Jean Delvare wrote:
> The Renesas R-Car GPIO driver is only useful on shmobile unless build
> testing.
> 
> Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>
> Cc: Magnus Damm <damm@xxxxxxxxxxxxx>
> Cc: Simon Horman <horms+renesas@xxxxxxxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: Alexandre Courbot <gnurou@xxxxxxxxx>
> ---
> Simon, is it correct? I couldn't remove the dependency on ARM because
> the driver uses set_irq_flags which is arm-specific.

Assuming that set_irq_flags is arm-specific then yes, I think this is
correct.

Acked-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>

> 
>  drivers/gpio/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-3.15-rc6.orig/drivers/gpio/Kconfig	2014-05-23 12:00:02.262995319 +0200
> +++ linux-3.15-rc6/drivers/gpio/Kconfig	2014-05-23 13:29:01.773035079 +0200
> @@ -259,7 +259,7 @@ config GPIO_PXA
>  
>  config GPIO_RCAR
>  	tristate "Renesas R-Car GPIO"
> -	depends on ARM
> +	depends on ARM && (ARCH_SHMOBILE || COMPILE_TEST)
>  	help
>  	  Say yes here to support GPIO on Renesas R-Car SoCs.
>  
> 
> 
> -- 
> Jean Delvare
> SUSE L3 Support
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html