Re: [PATCH 3/4] gpio: make handler_data configurable while using gpiolib_irqchip

[Barry Song <21cnbao@xxxxxxxxx>]

2014-04-24 21:06 GMT+08:00, Linus Walleij <linus.walleij@xxxxxxxxxx>:
> On Thu, Apr 24, 2014 at 1:23 AM, Barry Song <21cnbao@xxxxxxxxx> wrote:
>
>> my point is that will we make the gpiochip_set_chained_irqchip() more
>> general for this kind of cases too since you have had a good API to
>> wrap things?
>
> As it only wraps two function calls I'm leaning toward deleting it as it
> might create more complexity than it removes. Not sure.

i do agree that we can remove it if it doesn't really support general
gpiochip. i think it is popular that some gpiochip has several irq
parents. so people might get confused by this API as it actually
doesn't really help many.

>
> We don't have a similar handler for registering nested threaded
> irq handlers so it's not really helpful.
>
> Yours,
> Linus Walleij
>

-barry

-barry
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html