Re: [PATCH 3/4] gpio: make handler_data configurable while using gpiolib_irqchip

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Tue, Apr 15, 2014 at 8:43 AM, Barry Song <21cnbao@xxxxxxxxx> wrote:

> From: Barry Song <Baohua.Song@xxxxxxx>
>
> since it is called handler_data, drivers should have the ability to
> set handler_data based on real hardware.
> GPIOLIB_IRQCHIP doesn't use handler_data by itself, so it will not
> break GPIO core.
>
> Signed-off-by: Barry Song <Baohua.Song@xxxxxxx>

NAK, the whole idea with the function gpiochip_set_chained_irqchip()
is that its sets things up so that the gpiochip is passed as handler
data on the parent IRQ, akin to how the gpiochip is passed as
chip data on the cascaded IRQs.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html