On Thursday 04 February 2016 10:00:19 Yan, Zheng wrote:
> > On Feb 4, 2016, at 05:27, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> {
> struct ceph_timespec ts;
> ceph_encode_timespec(&ts, &req->r_stamp);
> ceph_encode_copy(&p, &ts, sizeof(ts));
> }
Ok, that does make the behavior consistent on all architectures, but
leads to a different question:
struct ceph_timespec {
__le32 tv_sec;
__le32 tv_nsec;
} __attribute__ ((packed));
How do you define ceph_timespec, is tv_sec supposed to be signed or unsigned?
It seems that you treat it as signed, meaning you interpret times
from the server as being in the [1902..2038] range, rather than the
[1970..2106] range:
static inline void ceph_decode_timespec(struct timespec *ts,
const struct ceph_timespec *tv)
{
ts->tv_sec = (__kernel_time_t)le32_to_cpu(tv->tv_sec);
ts->tv_nsec = (long)le32_to_cpu(tv->tv_nsec);
}
Is that intentional and documented? If yes, what is your plan to deal
with y2038 support?
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
