On Wednesday 03 February 2016 08:17:23 Deepa Dinamani wrote: > On Wed, Feb 03, 2016 at 10:34:00PM +0800, Yan, Zheng wrote: > > On Wed, Feb 3, 2016 at 2:07 PM, Deepa Dinamani <deepa.kernel@xxxxxxxxx> wrote: > > > --- a/fs/ceph/mds_client.c > > > +++ b/fs/ceph/mds_client.c > > > @@ -1721,7 +1721,7 @@ ceph_mdsc_create_request(struct ceph_mds_client *mdsc, int op, int mode) > > > init_completion(&req->r_safe_completion); > > > INIT_LIST_HEAD(&req->r_unsafe_item); > > > > > > - req->r_stamp = CURRENT_TIME; > > > + ktime_get_real_ts(&req->r_stamp); > > > > I think we should use current_fs_time() here. I have squash the change > > into another patch > > Ok. I missed this commit b8e69066d8afa8d2670dc697252ff0e5907aafad > earlier which says that the r_stamp is used as ctime now. > I had assumed that this is a message timestamp. > > I was not able to find any documentation on what the server does > with the message sent by the client. Where can I find that? > > So, this should actually look like > > req->r_stamp = current_fs_time(mdsc->fsc->sb); > > Let me know if you want me to resend. I see that the timestamp is sent using ceph_encode_copy(&p, &req->r_stamp, sizeof(req->r_stamp)); What happens with the timestamp across reboots if we change the type? I assume the data will not be used across reboots, if it does, we already have a problem on machines that can boot both big-endian and little-endian kernels, or that can boot both 32-bit and 64-bit kernels. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
