Re: [PATCH 1/2] mm,fs,dax: Change ->pmd_fault to ->huge_fault

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 28, 2016 at 01:17:10PM +0100, Jan Kara wrote:
> >  {
> > +	struct vm_fault vmf = {
> > +		.virtual_address = (void __user *)address,
> > +		.flags = flags | FAULT_FLAG_SIZE_PMD,
> > +		.pmd = pmd,
> > +	};
> > +
> 
> I think we should fill in also the vmf.gfp_mask and vmf.pgoff fields. I
> know they are not currently used but it would be a nasty surprise if
> someone tried to use them in the future...

Hmm.  We probably should try to use gfp_mask and pgoff.  I'll note those for
a future patch series, and I'll initialise them now.  Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux