The Makefile currently controlling compilation of this code is obj-y meaning that it currently is not being built as a module by anyone. Lets remove the traces of modularity that we can so that when reading the code there is no doubt it is builtin-only. Since module_init translates to device_initcall in the non-modular case, the init ordering gets bumped to one level earlier when we use the more appropriate fs_initcall here. However we've made similar changes before without any fallout and none is expected here either. We can't remove module.h from the file as we've done in similar cleanups, since other code in the file is using module functions to try and load filesystem drivers etc. Cc: Alexander Viro <viro@xxxxxxxxxxxxxxxxxx> Cc: linux-fsdevel@xxxxxxxxxxxxxxx Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> --- fs/filesystems.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/filesystems.c b/fs/filesystems.c index 5797d45a78cb..3bca451b1e80 100644 --- a/fs/filesystems.c +++ b/fs/filesystems.c @@ -253,7 +253,7 @@ static int __init proc_filesystems_init(void) proc_create("filesystems", 0, NULL, &filesystems_proc_fops); return 0; } -module_init(proc_filesystems_init); +fs_initcall(proc_filesystems_init); #endif static struct file_system_type *__get_fs_type(const char *name, int len) -- 2.6.1 -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html