Looks like exofs_new_inode() does this
inode->i_ino = sbi->s_nextid++;
without any locking; sure, the parent directory is locked, but that's not
worth much on a filesystem that supports mkdir()... Am I missing something
subtle here? Another question in the code nearby:
ret = ore_get_io_state(&sbi->layout, &oi->oc, &ios);
if (unlikely(ret)) {
EXOFS_ERR("exofs_new_inode: ore_get_io_state failed\n");
return ERR_PTR(ret);
}
aren't we leaking a struct inode here? Path around ore_create() is
also interesting - looks like its failure causes a leak (at least if
it happens early on)...
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
