> -----Original Message----- > From: Borislav Petkov [mailto:bp@xxxxxxxxx] > Sent: Sunday, November 01, 2015 6:58 PM > > On Sun, Nov 01, 2015 at 10:52:52AM +0000, Kweh, Hock Leong wrote: > > Could you share me your dumb file? I did perform negative test, but I did > > not get these dump stack in dmesg. Thanks. > > I think almost any file works: > > cat /bin/ls > /dev/efi_capsule_loader Ok. Will try this out. > > > > > +#define UPLOAD_DONE -1 > > > > > > Isn't the fact that upload was finished a success message? If so, why is it a > > > negative value? > > > > This is to indicate an upload is done and pending for close(2). If a > subsequence > > write(2) perform, return error. Comments inputted by Matt and Andy. > > But in that case you can return ERR_OCCURRED. UPLOAD_DONE still doesn't > look like a negative value to me as it signals that the upload was done > and thus successful as no errors happened during the upload. > Hmm .... If I combine these 2 flags to become one as "NO_MORE_WRITE_ACTION" to better describing the situation, you Okay with it? Regards, Wilson ��.n��������+%������w��{.n�����{���)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
