Re: [PATCH 09/17] fs/hpfs: remove unnecessary new_valid_dev check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Wed, 30 Sep 2015, Yaowei Bai wrote:

> On Tue, Sep 29, 2015 at 05:03:24PM +0200, Mikulas Patocka wrote:
> > Hi
> > 
> > I suppose that you should remove the function new_valid_dev at all.
> 
> Yes, i thought about that, but actually there's still a user of
> new_valid_dev in fs/stat.c:
> 
> 	#define valid_dev(x)  choose_32_64(old_valid_dev,new_valid_dev)(x)
> 
> so i just left new_valid_dev untouched and removed other users in fs first.

So, remove that too - change it to choose_32_64(old_valid_dev(x),true)

If you remove most calls for the function new_valid_dev, the function is 
meaningless and shouldn't be present in the source code.

Mikulas
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux