On Wed, Aug 26, 2015 at 09:21:54AM -0700, Darrick J. Wong wrote: > On Wed, Aug 26, 2015 at 03:37:23PM +0200, David Sterba wrote: > > On Wed, Aug 26, 2015 at 04:16:42PM +0800, Peng Tao wrote: > > > +struct file_clone_range { > > > + __s64 src_fd; > > > + __u64 src_offset; > > > + __u64 src_length; > > > + __u64 dest_offset; > > > +}; > > > > Might be a good idea to add some spare bytes to the structure. > > But... structure size is encoded in the ioctl definition, so adding bytes > to struct file_clone_range now will change the ioctl number and break > userland. Oh right, I somehow did not left idea of a new ioctl definition while writing it. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html