On Mon, Aug 10, 2015 at 05:36:37AM +0100, Al Viro wrote: > Your unlock_namespace_rename() should've been a static inline. > With the check of unlock != NULL done in there. Two such inlines, > actually, and to hell with the boolean argument. Same split for the > lock counterpart, of course. PS: that thing should be in fs/dcache.c, at least in the part that deals with finding the common ancestor, etc. And __d_move() (and dentry_lock_for_move()) games with d_ancestor() should be redundant now. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html