Re: [PATCH review 5/6] vfs: Test for and handle paths that are unreachable from their mnt_root

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
Subject: Re: [PATCH review 5/6] vfs: Test for and handle paths that are unreachable from their mnt_root
From: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Date: Mon, 10 Aug 2015 05:38:14 +0100
Cc: Linux Containers <containers@xxxxxxxxxxxxxxxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, Andy Lutomirski <luto@xxxxxxxxxxxxxx>, "Serge E. Hallyn" <serge@xxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Andrey Vagin <avagin@xxxxxxxxxx>, Jann Horn <jann@xxxxxxxxx>, Willy Tarreau <w@xxxxxx>, Omar Sandoval <osandov@xxxxxxxxxxx>, Miklos Szeredi <miklos@xxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, "J. Bruce Fields" <bfields@xxxxxxxxxxxx>
In-reply-to: <878u9s9i1d.fsf_-_@x220.int.ebiederm.org>
User-agent: Mutt/1.5.21 (2010-09-15)

On Mon, Aug 03, 2015 at 04:30:22PM -0500, Eric W. Biederman wrote:

> +	if (!is_subdir(nd->path.dentry, mnt->mnt_root))
> +		return false;

Umm...  What's to protect us from racing with d_move() right here?
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Follow-Ups:
- Re: [PATCH review 5/6] vfs: Test for and handle paths that are unreachable from their mnt_root
  - From: Eric W. Biederman

References:
- [PATCH review 0/9] Call for testing and review of mount detach fixes
  - From: Eric W. Biederman
- [PATCH review 0/11 Call for testing and review of mount detach fixes (take 2)
  - From: Eric W. Biederman
- [PATCH review 0/19] Locked mount and loopback mount fixes
  - From: Eric W. Biederman
- [PATCH review 0/4] Loopback mount escape fixes
  - From: Eric W. Biederman
- [PATCH review 0/6] Bind mount escape fixes
  - From: Eric W. Biederman
- [PATCH review 5/6] vfs: Test for and handle paths that are unreachable from their mnt_root
  - From: Eric W. Biederman

Prev by Date: Re: [PATCH review 4/6] mnt: Track when a directory escapes a bind mount
Next by Date: Re: [PATCH review 4/6] mnt: Track when a directory escapes a bind mount
Previous by thread: [PATCH review 5/6] vfs: Test for and handle paths that are unreachable from their mnt_root
Next by thread: Re: [PATCH review 5/6] vfs: Test for and handle paths that are unreachable from their mnt_root
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]