On Mon, Feb 23, 2015 at 01:58:47PM -0800, Christoph Hellwig wrote: > On Mon, Feb 23, 2015 at 01:56:34PM -0800, Guenter Roeck wrote: > > Guess there a philosophical difference in opinion if the architecture code > > should (have to) provide copy_user_page() or not outside the architecture > > code itself. After all, fs/dax.c _is_ the only user of this function outside > > the architecture code. > > Given that copy_user_page just is an optimized version of copy_page > all these architectures should just grab the trivial macro defintion > from the asm-generic version so that we could avoid this discussion. > I tried to do just that, for mips, with little success. https://patchwork.linux-mips.org/patch/9175/ Presumably, if copy_page() followed by a conditional flush_data_cache_page() does not work on mips, I would assume that copy_page() without flush does not work either. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
