Re: [PATCH 2/5] fs: saner aio_complete prototype

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 27, 2015 at 06:55:10PM +0100, Christoph Hellwig wrote:
> Pass the result as a ssize_t, which is what we use for these returns
> all over the kernel.  Remove the res2 argument that all relevant
> callers always pass as '0'.

AFAICS, ->res2 is a part of user-visible ABI and drivers/usb/gadget ones
sure as hell don't look like as if it was 0:

> -	aio_complete(io_data->kiocb, ret, ret);
> -	aio_complete(iocb, ret, ret);
> -		aio_complete(iocb, req->actual ? req->actual : req->status,
> -				req->status);

What am I missing here?
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux