All cifs_direct_io does is return -EINVAL On Thu, Jan 22, 2015 at 11:13 AM, Thanos Makatos <thanos.makatos@xxxxxxxxxx> wrote: > In dca692880e887739a669f6c41a80ca68ce2b09fc I see that ".direct_IO = cifs_direct_io" is added only to "cifs_addr_ops" but not to "cifs_addr_ops_smallbuf". > Presuming that the only difference between the two structs is the size of the buffer they operate on (judging by the name), shouldn't ".direct_IO = cifs_direct_io" be added to "cifs_addr_ops_smallbuf" as well? > In a test environment an open(2) using O_DIRECT didn't work (vers=3.0) but when I added ".direct_IO = cifs_direct_io" to "cifs_addr_ops_smallbuf" it worked. > > -- > Thanos Makatos-- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
