Hi, Kirill A. Shutemov wrote on Mon, Dec 29, 2014 at 03:00:18PM +0200: > p9_client_lock_dotl() doesn't set status if p9_client_rpc() fails. > It can lead to 'default:' case in switch below and kernel crashes. > > [ 17.965643] ------------[ cut here ]------------ > ... > [ 17.965824] ---[ end trace 1cfc767bf06625a1 ]--- > > Let's bypass the switch if p9_client_lock_dotl() fails. Kirill A. Shutemov wrote on Mon, Dec 29, 2014 at 03:00:19PM +0200: > Current 9p implementation will crash whole system if sees unkown lock > status code. It's trivial target for DOS: 9p server can produce such > code easily. > > Let's fallback more gracefully: warning in dmesg + -ENOLCK. Both patches look good to me, for what it's worth. There's alot of work waiting if we want to protect ourselves from malicious servers, but it's all good to take :) -- Dominique Martinet, CEA -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
