On Mon, Oct 27, 2014 at 5:56 AM, Dave Chinner <david@xxxxxxxxxxxxx> wrote: > On Sun, Oct 26, 2014 at 01:22:53PM +0800, Li Xi wrote: >> This patch adds FS_IOC_FSSETXATTR/FS_IOC_FSGETXATTR ioctl interface >> support for ext4. The interface is kept consistent with >> XFS_IOC_FSGETXATTR/XFS_IOC_FSGETXATTR. > > What you haven't mentioned is that you also changed the fsxattr > interface structure to add functionality and new behaviours that > isn't supported by XFS or existing applications that use the > interface. > > There is no need to modify the interface *at all* for ext4 to use > it. Fields that ext4 does not use can be zeroed on getxattr, and > ignored on setxattr - you do not need to add new fields to say what > fields are valid. Sorry, I don't want to change the interfaces either. But, the problem is that zero might be valid value for some fields. How can we distinguish an unsupported attribute and an attribute whose value is zero? It is common case the only part of the fields are supported. So, for example, if we don't have valid flags, how can use space application tell kernel which attributes should be skipped when it tries to set only a part of atrributes? Regards, Li Xi -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
