On Sun, Oct 26, 2014 at 01:22:53PM +0800, Li Xi wrote: > This patch adds FS_IOC_FSSETXATTR/FS_IOC_FSGETXATTR ioctl interface > support for ext4. The interface is kept consistent with > XFS_IOC_FSGETXATTR/XFS_IOC_FSGETXATTR. What you haven't mentioned is that you also changed the fsxattr interface structure to add functionality and new behaviours that isn't supported by XFS or existing applications that use the interface. There is no need to modify the interface *at all* for ext4 to use it. Fields that ext4 does not use can be zeroed on getxattr, and ignored on setxattr - you do not need to add new fields to say what fields are valid. > +/* > + * Extend attribute flags. These should be or-ed together to figure out what > + * is valid. > + */ > +#define FSX_XFLAGS (1 << 0) > +#define FSX_EXTSIZE (1 << 1) > +#define FSX_NEXTENTS (1 << 2) > +#define FSX_PROJID (1 << 3) They are not interface definition flags - these are internal XFS flags to tell an internal shared function what the caller was modifying. I actually have a series of patches that removes them because the internal XFS code shouldn't be shared in this way. As such, they shouldn't be propagated into the user interface for the ioctls.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
