On Thu, Oct 23, 2014 at 07:05:11PM +0100, Al Viro wrote: > On Thu, Oct 23, 2014 at 01:54:28PM -0400, J. Bruce Fields wrote: > > > > Hmm... Not in the current mainline (and not because of want_discon - that's > > > gone already). However, with the fixes I've got in the local tree it > > > will both find and move it - same as d_materialise_unique() would in the > > > current mainline. > > > > What happened to the idea of failing with -EIO in that case? > > Quiet d_move() is definitely better in this case. Can you explain why? (Apologies if I'm missing the obvious.) --b. > Failing with EIO is what > d_splice_alias() does *now*, and that's why the patch I've posted uses > d_materialise_unique(). Patches in my local tree switch that case of > d_splice_alias() to what d_materialise_unique() does (and kill > d_materialise_unique() completely - compat #define is left, but all > in-tree users are switched to d_splice_alias())... -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
