On Thu, Oct 23, 2014 at 05:55:33PM +0100, Al Viro wrote: > On Fri, Oct 24, 2014 at 01:45:49AM +0900, OGAWA Hirofumi wrote: > > > d_splice_alias() calls __d_find_alias() with want_discon==1, so > > __d_find_alias() doesn't return dentry, and d_splice_alias() doesn't use > > d_move() path, right? > > Hmm... Not in the current mainline (and not because of want_discon - that's > gone already). However, with the fixes I've got in the local tree it > will both find and move it - same as d_materialise_unique() would in the > current mainline. What happened to the idea of failing with -EIO in that case? In the case of a disk filesystem it seems like it can only happen due to corruption and I'd assumed we're better off failing the first time we notice it. (That said, I haven't thought it through beyond that, so it's not something I have that strong an opinion on.) --b. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
