Re: Name hashing function causing a perf regression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 12, 2014 at 3:25 PM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> So with that, the kernel patch would look something like the attached.
> Totally untested.

Tested here, and it looks ok. The hash_64() implementation meant that
even on x86-64, where multiplies are generally fast, we'd do manual
shift-and-adds. Which annoyed me, although it didn't show up as a huge
problem in profiles. So I cleaned some of that up too.

I'm not going to wait for the next merge window, since we still have a
couple of weeks to go for 3.17. But I also didn't necessarily mark it
for stable, since I want to hear about how this affects performance at
fb first.

So if this all helps you guys, and after sufficient testing, just the
current top commit should be self-sufficient (with two other commits
before *if* that multiply-vs-shift makes a difference)

    99d263d4c5b2 (HEAD, master) vfs: fix bad hashing of dentries

and if it *doesn't* help, and you still see problems, please holler.

            Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux