On Tue, Jul 29, 2014 at 06:39:53PM +0100, Rob Jones wrote: > At the moment these consumers have to obtain the struct seq_file pointer > (stored by seq_open() in file->private_data) and then store a pointer to > their own data in the private field of the struct seq_file so that it > can be accessed by the iterator functions. > > Although this is not a long piece of code it is unneccessary boilerplate. How many of those do we actually have? > seq_open() remains in place and its behaviour remains unchanged so no > existing code should be broken by this patch. I have no objections against such helper, but I's rather have it implemented via seq_open() (and as a static inline, not an export), not the other way round. Oh, and conversion of at least some users would be nice to have as well... -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
