Two points about latest version (dentry_kill-2): - Doing anything with dentry->d_parent in case of DCACHE_DENTRY_KILLED looks seriously wrong. Parent has been dealt with, at that point, by the other caller, no? - "bool foo = flag & FLAG" looks suspicious. Is this guaranteed not to overflow? Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html