On Wed, Mar 19, 2014 at 04:45:47PM -0400, Jeff Layton wrote:
> It's best to let the compiler decide that.
Acked-by: J. Bruce Fields <bfields@xxxxxxxxxx>
>
> Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
> ---
> fs/locks.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/fs/locks.c b/fs/locks.c
> index 5e28612120c2..049a14402ee4 100644
> --- a/fs/locks.c
> +++ b/fs/locks.c
> @@ -511,8 +511,7 @@ static int posix_same_owner(struct file_lock *fl1, struct file_lock *fl2)
> }
>
> /* Must be called with the i_lock held! */
> -static inline void
> -locks_insert_global_locks(struct file_lock *fl)
> +static void locks_insert_global_locks(struct file_lock *fl)
> {
> lg_local_lock(&file_lock_lglock);
> fl->fl_link_cpu = smp_processor_id();
> @@ -521,8 +520,7 @@ locks_insert_global_locks(struct file_lock *fl)
> }
>
> /* Must be called with the i_lock held! */
> -static inline void
> -locks_delete_global_locks(struct file_lock *fl)
> +static void locks_delete_global_locks(struct file_lock *fl)
> {
> /*
> * Avoid taking lock if already unhashed. This is safe since this check
> @@ -544,14 +542,12 @@ posix_owner_key(struct file_lock *fl)
> return (unsigned long)fl->fl_owner;
> }
>
> -static inline void
> -locks_insert_global_blocked(struct file_lock *waiter)
> +static void locks_insert_global_blocked(struct file_lock *waiter)
> {
> hash_add(blocked_hash, &waiter->fl_link, posix_owner_key(waiter));
> }
>
> -static inline void
> -locks_delete_global_blocked(struct file_lock *waiter)
> +static void locks_delete_global_blocked(struct file_lock *waiter)
> {
> hash_del(&waiter->fl_link);
> }
> --
> 1.8.5.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
