On Tue, 11 Feb 2014 13:49:15 -0800 (PST) Roland McGrath <roland@xxxxxxxxxxxxx> wrote: > > +2014-02-11 Jeff Layton <jlayton@xxxxxxxxxx> > > + > > + * add new fcntl cmd macros for file-private locks > > Proper format is: > > * sysdeps/unix/sysv/linux/bits/fcntl-linux.h > (F_GETLKP, F_SETLKP, F_SETLKPW): New macros. > > > +/* > > + * fd "private" POSIX locks. > > + * > > + * Usually POSIX locks held by a process are released on *any* close and are > > + * not inherited across a fork(). > > Use GNU style for comments, as you see elsewhere in the file. Use two > spaces between sentences. Don't use "function()" when referring to a > function, just the name. > > > +#ifndef F_GETLKP > > +# define F_GETLKP 36 > > +# define F_SETLKP 37 > > +# define F_SETLKPW 38 > > +#endif > > These need to be protected by #ifdef __USE_GNU. Thanks for the comments, Roland. I'll fix the patch accordingly. My plan is to eventually submit this to become part of the POSIX standard though they won't take it until there's at least one shipping implementation. I assume that we just need to stick that inside of __USE_GNU for now, and if POSIX eventually picks it up then we'll just remove that protection? Also, I'm a little curious in looking at this and have a (probably stupid) question: Why does glibc have its own definitions for the fcntl F_* cmd values instead of using the ones in the uapi kernel headers? Would it not be simpler to just have the fcntl.h include those instead of duplicating them? Thanks, -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
