-------------------------------------------- On Fri, 7/2/14, Vyacheslav Dubeyko <slava@xxxxxxxxxxx> wrote: Subject: Re: [PATCH v2 00/15] hfsplus: introduce journal replay functionality To: "Andrew Morton" <akpm@xxxxxxxxxxxxxxxxxxxx> Cc: "Linux FS devel list" <linux-fsdevel@xxxxxxxxxxxxxxx>, "Al Viro" <viro@xxxxxxxxxxxxxxxxxx>, "ChristophHellwig" <hch@xxxxxxxxxxxxx>, "Hin-Tak Leung" <htl10@xxxxxxxxxxxxxxxxxxxxx> Date: Friday, 7 February, 2014, 6:05 Hi Andrew, On Thu, 2014-02-06 at 10:21 +0400, Vyacheslav Dubeyko wrote: > On Wed, 2014-02-05 at 15:48 -0800, Andrew Morton wrote: > > On Fri, 24 Jan 2014 19:25:18 +0400 Vyacheslav Dubeyko <slava@xxxxxxxxxxx> wrote: > > > > > This second version of patchset that implements journal replay > > > functionality in HFS+ file system driver. > > > > The series introduces a lot of build glitches on i386 (and other 32-bit > > builds) > > > > - tons of printk mismatch warnings > > > > - unresolvable references to __udivdi3 and __umoddi3 (need to use > > do_div() or similar). > > > > - several bisection holes: > > > > - with 4 patches applied, error: implicit declaration of function 'JHDR_SIZE' > > > > - with three patches applied, warning: 'hfsplus_create_journal' used but never defined > > I've reproduced (1) printk mismatch warnings; and (2) unresolvable references to __udivdi3 and __umoddi3 build issues. But I am unable to reproduce the issue with JHDR_SIZE and hfsplus_create_journal. And I assume that I misunderstand something. This declarations live inside of journal.c file only. And I add journal.c file in Makefile in 0015-hfsplus-integrate-journal-replay-support-into-driver.patch only. So, how do you achieve build issues with JHDR_SIZE and hfsplus_create_journal? Could you share your way? Maybe do you use some special compilation options or additional tools during build? Thanks, Vyacheslav Dubeyko. Hi Vyacheslav, I came across this patch (http://marc.info/?l=linux-fsdevel&m=138446099500610&w=2) about an earlier __divdi3 issue - the analysis is quite thorough and I think relevant for the __udivdi3 / __umoddi3 issues. Hope this helps. Hin-Tak -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
