Hi Andrew, On Thu, 2014-02-06 at 10:21 +0400, Vyacheslav Dubeyko wrote: > On Wed, 2014-02-05 at 15:48 -0800, Andrew Morton wrote: > > On Fri, 24 Jan 2014 19:25:18 +0400 Vyacheslav Dubeyko <slava@xxxxxxxxxxx> wrote: > > > > > This second version of patchset that implements journal replay > > > functionality in HFS+ file system driver. > > > > The series introduces a lot of build glitches on i386 (and other 32-bit > > builds) > > > > - tons of printk mismatch warnings > > > > - unresolvable references to __udivdi3 and __umoddi3 (need to use > > do_div() or similar). > > > > - several bisection holes: > > > > - with 4 patches applied, error: implicit declaration of function 'JHDR_SIZE' > > > > - with three patches applied, warning: 'hfsplus_create_journal' used but never defined > > I've reproduced (1) printk mismatch warnings; and (2) unresolvable references to __udivdi3 and __umoddi3 build issues. But I am unable to reproduce the issue with JHDR_SIZE and hfsplus_create_journal. And I assume that I misunderstand something. This declarations live inside of journal.c file only. And I add journal.c file in Makefile in 0015-hfsplus-integrate-journal-replay-support-into-driver.patch only. So, how do you achieve build issues with JHDR_SIZE and hfsplus_create_journal? Could you share your way? Maybe do you use some special compilation options or additional tools during build? Thanks, Vyacheslav Dubeyko. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html