On Wed 11-12-13 03:27:55, Christoph Hellwig wrote:
> > static int dnotify_handle_event(struct fsnotify_group *group,
> > + struct inode *to_tell,
>
> Can we just call this variable inode? :)
OK, done.
> > @@ -155,7 +154,7 @@ static struct fsnotify_ops dnotify_fsnotify_ops = {
> > .should_send_event = dnotify_should_send_event,
> > .free_group_priv = NULL,
> > .freeing_mark = NULL,
> > - .free_event_priv = NULL,
> > + .free_event = NULL,
> > };
>
> Please also drop all thee pointless NULL method initializations.
OK, I did this for all notification users as a separate patch.
> > +struct fsnotify_event {
> > + struct list_head list;
> > + /* to_tell may ONLY be dereferenced during handle_event(). */
> > + struct inode *to_tell; /* either the inode the event happened to or its parent */
>
> Again, I'd just call this member inode.
>
> Looks good except for the minor nitpicks,
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
Honza
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
