Sage, I've taken David's latest changes and per his request merged his 'fscache-fixes-for-ceph' tag then applied my changes on top of that. In addition to the pervious changes I also added a fix for the warnings the linux-next build bot found. I've given the results a quick test to make sure it builds, boots and runs okay. The code is located in my repository: https://adfin@xxxxxxxxxxxxx/adfin/linux-fs.git in the wip-fscache-v2 branch I hope that this is the final go for now and thanks for everyone's patience. - Milosz On Fri, Sep 6, 2013 at 11:59 AM, David Howells <dhowells@xxxxxxxxxx> wrote: > Milosz Tanski <milosz@xxxxxxxxx> wrote: > >> After running this for a day on some loaded machines I ran into what >> looks like an old issue with the new code. I remember you saw an issue >> that manifested it self in a similar way a while back. >> >> [13837253.462779] FS-Cache: Assertion failed >> [13837253.462782] 3 == 5 is false >> [13837253.462807] ------------[ cut here ]------------ >> [13837253.462811] kernel BUG at fs/fscache/operation.c:414! > > Bah. > > I forgot to call fscache_op_complete(). Patch updated and repushed. > > Btw, I've reordered the patches to put the CIFS patch last. Can you merge the > patches prior to the CIFS commit from my branch rather than cherry picking > them so that if they go via two different routes, GIT will handle the merge > correctly? I've stuck a tag on it (fscache-fixes-for-ceph) to make that > easier for you. > > I've also asked another RH engineer to try doing some basic testing on the > CIFS stuff - which may validate the fscache_readpages_cancel patch. > > David -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
