On Mon, Sep 02, 2013 at 02:52:20PM -0700, Eric W. Biederman wrote: > So yes it does look like the case that except for the first iteration ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > the test at the top of the while loop is now redundant, because of the > if (!q) break; that I added. Ah... I see the confusion now. The test is redundant on the first iteration as well. The test is entirely redundant. That's the point. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html