On Mon, Sep 02, 2013 at 01:30:00PM -0700, Eric W. Biederman wrote: > Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes: > > > Hello Eric W. Biederman, > > > > This is a semi-automatic email about new static checker warnings. > > > > The patch 4ce5d2b1a8fd: "vfs: Don't copy mount bind mounts of > > /proc/<pid>/ns/mnt between namespaces" from Mar 30, 2013, leads to > > the following Smatch complaint: > > Semi-autoautomatic reply. The test !q is enough to ensure p is valid > until p->mnt.mnt_root == q->mnt.mnt_root. > > This has been verified through both testing and reading of the code. > Why not make the test: while (1) { ... regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html