On Fri, 2013-08-30 at 12:06 +1000, Michael Neuling wrote:
> powerpc patch below. I'm using arch_spin_is_locked() to implement
> arch_spin_value_unlocked().
>
> +static __always_inline int arch_spin_value_unlocked(arch_spinlock_t lock)
> +{
> + return !arch_spin_is_locked(&lock);
> +}
> +
Arguably, it should be done the other way around :-)
arch_spin_value_unlocked semantics is to basically operate on an already
read copy of the value, while arch_spin_is_locked() has ACCESS_ONE
semantics on *top* of that.
Or we can keep both completely separate like Linus does on x86.
Cheers,
Ben.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
