On 2013/7/18 20:02, Vyacheslav Dubeyko wrote:
>
> On Jul 17, 2013, at 8:23 AM, Prasad Joshi wrote:
>
>> On Tue, Jul 16, 2013 at 3:03 PM, Younger Liu <younger.liu@xxxxxxxxxx> wrote:
>>>
>>> In get_mapping_page(), after calling find_or_create_page(),
>>> the return value should be checked.
>>>
>>> Signed-off-by: Younger Liu <younger.liu@xxxxxxxxxx>
>>
>> Thanks applied.
>>
>> Regards,
>> Prasad
>>
>>> ---
>>> fs/logfs/segment.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/fs/logfs/segment.c b/fs/logfs/segment.c
>>> index 038da09..2641e94 100644
>>> --- a/fs/logfs/segment.c
>>> +++ b/fs/logfs/segment.c
>>> @@ -62,7 +62,8 @@ static struct page *get_mapping_page(struct super_block
>>> *sb, pgoff_t index,
>>> page = read_cache_page(mapping, index, filler, sb);
>>> else {
>>> page = find_or_create_page(mapping, index, GFP_NOFS);
>>> - unlock_page(page);
>>> + if(page)
>
> Sorry, but as I understand, this code breaks kernel coding style.
>
> With the best regards,
> Vyacheslav Dubeyko.
>
>>> + unlock_page(page);
>>> }
>>> return page;
>>> }
>>> -- 1.7.9.7
>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
>
Hi, Prasad and Vyacheslav
I modified the coding style, and resent a new patch.
Please drop the last patch, and apply this new patch.
thanks.
Signed-off-by: Younger Liu <younger.liu@xxxxxxxxxx>
---
fs/logfs/segment.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/logfs/segment.c b/fs/logfs/segment.c
index d448a77..7f9b096 100644
--- a/fs/logfs/segment.c
+++ b/fs/logfs/segment.c
@@ -62,7 +62,8 @@ static struct page *get_mapping_page(struct super_block *sb, pgoff_t index,
page = read_cache_page(mapping, index, filler, sb);
else {
page = find_or_create_page(mapping, index, GFP_NOFS);
- unlock_page(page);
+ if (page)
+ unlock_page(page);
}
return page;
}
--
1.7.9.7
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
