Re: [RESENT PATCH] logfs: Check for the return value after calling find_or_create_page()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 16, 2013 at 3:03 PM, Younger Liu <younger.liu@xxxxxxxxxx> wrote:
>
> In get_mapping_page(), after calling find_or_create_page(),
> the return value should be checked.
>
> Signed-off-by: Younger Liu <younger.liu@xxxxxxxxxx>

Thanks applied.

Regards,
Prasad

> ---
>  fs/logfs/segment.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/logfs/segment.c b/fs/logfs/segment.c
> index 038da09..2641e94 100644
> --- a/fs/logfs/segment.c
> +++ b/fs/logfs/segment.c
> @@ -62,7 +62,8 @@ static struct page *get_mapping_page(struct super_block
> *sb, pgoff_t index,
>                 page = read_cache_page(mapping, index, filler, sb);
>         else {
>                 page = find_or_create_page(mapping, index, GFP_NOFS);
> -               unlock_page(page);
> +               if(page)
> +                       unlock_page(page);
>         }
>         return page;
>  }
> -- 1.7.9.7
>
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux