Re: [PATCH v11 25/25] list_lru: dynamically adjust node arrays

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2013-06-19 at 10:14 -0700, Andrew Morton wrote:
> On Wed, 19 Jun 2013 17:29:06 +0400 Glauber Costa <glommer@xxxxxxxxx> wrote:
> 
> > > > Thanks for taking a look at this.
> > > > 
> > > > list_lru_destroy is called by deactivate_lock_super, so we should be fine already.
> > > 
> > > Sorry, I'm a little confused...
> > > 
> > > I didn't see list_lru_destroy() called in deactivate_locked_super().
> > > Maybe I missed something? 
> > 
> > Err... the code in my tree reads:
> > 
> >         unregister_shrinker(&s->s_shrink);
> >         list_lru_destroy(&s->s_dentry_lru);
> >         list_lru_destroy(&s->s_inode_lru);
> >         put_filesystem(fs);
> >         put_super(s);
> > 
> > But then I have just checked Andrew's, and it is not there - thank you.
> 
> That is added by "super: targeted memcg reclaim", which is in the part
> of the series which we decided to defer.

Oh, yes, there it is. Sorry for the noise ...

> 
> > Andrew, should I send a patch for you to fold it ?
> 
> Sure.  Perhaps you could check for any other things which should be
> brought over from the not-merged-yet patches?
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux