On Wed, 19 Jun 2013 17:29:06 +0400 Glauber Costa <glommer@xxxxxxxxx> wrote: > > > Thanks for taking a look at this. > > > > > > list_lru_destroy is called by deactivate_lock_super, so we should be fine already. > > > > Sorry, I'm a little confused... > > > > I didn't see list_lru_destroy() called in deactivate_locked_super(). > > Maybe I missed something? > > Err... the code in my tree reads: > > unregister_shrinker(&s->s_shrink); > list_lru_destroy(&s->s_dentry_lru); > list_lru_destroy(&s->s_inode_lru); > put_filesystem(fs); > put_super(s); > > But then I have just checked Andrew's, and it is not there - thank you. That is added by "super: targeted memcg reclaim", which is in the part of the series which we decided to defer. > Andrew, should I send a patch for you to fold it ? Sure. Perhaps you could check for any other things which should be brought over from the not-merged-yet patches? -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html