On Sat, Jun 15, 2013 at 06:09:39AM +0100, Al Viro wrote: > BTW, in ncp_fill_cache() we have a provably pointless > if (!ino) > ino = find_inode_number(dentry, &qname); > Check it out - any path that can lead there with ino == 0 will *not* > have a positive dentry with such name, so this find_inode_number() > call is just "waste some time and return 0". Cargo-cult, plain and > simple... Incidentally, the only other caller of find_inode_number() is equally pointless, so I'm very inclined to kill the damn function off. Sure, it's exported. And I'm fairly sure that its out-of-tree users are just as fishy (as in Innsmouth)... -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
