2013/4/3, Jaegeuk Kim <jaegeuk.kim@xxxxxxxxxxx>: Hi. Jaegeuk. > Hi, > > Agreed, and send v2. > > Change log from v1: > o remain read_node_page and remove the lock part > > From 04006aecac2882c574fe8a7de926bc52c73a8ad1 Mon Sep 17 00:00:00 2001 > From: Jaegeuk Kim <jaegeuk.kim@xxxxxxxxxxx> > Date: Sun, 31 Mar 2013 12:47:20 +0900 > Subject: [PATCH] f2fs: remove redundant lock_page calls > Cc: linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, > linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx > > In get_node_page, we do not need to call lock_page all the time. > > If the node page is cached as uptodate, > > 1. grab_cache_page locks the page, > 2. read_node_page unlocks the page, and > 3. lock_page is called for further process. > > Let's avoid this. > > Signed-off-by: Jaegeuk Kim <jaegeuk.kim@xxxxxxxxxxx> Yes, Looks good! Reviewed-by: Namjae Jeon <namjae.jeon@xxxxxxxxxxx> Thanks. > --- -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
