2013/4/1, Jaegeuk Kim <jaegeuk.kim@xxxxxxxxxxx>: > In get_node_page, we do not need to call lock_page all the time. > > If the node page is cached as uptodate, > > 1. grab_cache_page locks the page, > 2. read_node_page unlocks the page, and > 3. lock_page is called for further process. > > Let's avoid this. Instead of removing the function "read_node_page" completely to avoid the redundant locking, we can simply remove the "unlock" part from the read_node_page and use the same code in ra_node_page, get_node_page, get_node_page_ra.. With this patch change, the same code is getting repeated at several places and IMHO It is not good for the puprose of the modularity. Please share your opinion. Thanks. > > Signed-off-by: Jaegeuk Kim <jaegeuk.kim@xxxxxxxxxxx> > --- -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
