On Fri, Jan 18, 2013 at 06:01:28PM -0500, Theodore Ts'o wrote: > .... and can we get rid of this horrible hack where we have this > bastardized use of a struct buffer_head which is allocated on the > stack, which has nothing really to do with a buffer head, and is all > about the fact that no one wants to change the function signature for > get_block_t? I have patches to do that, but they are on the back burner right now because it causes some kind of weird corruption in the pwritev case that kvm uses to issue IO (i.e. large iovecs of 4k segments). IMO, the direct IO code is that complex and convoluted now that t is close to impossible to modify without introduce some weird, subtle and almost impossible to debug issue. The code has been optimised to the point of being unmaintainable, and I have seriously considered just reimplementing the bits XFS needs just for XFS several times in the past year.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
