On Tue, 2012-12-18 at 14:47 -0800, Andrew Morton wrote: > On Wed, 14 Nov 2012 16:50:53 +0400 > Vyacheslav Dubeyko <slava@xxxxxxxxxxx> wrote: > > > On Tue, 2012-11-13 at 14:34 -0800, Andrew Morton wrote: > > > > [snip] > > > > > > The code is missing a flush_dcache_page()? We should have one in there > > > after the CPU has modified userspace-mappable page contents. > > > > > > > Yes, I think your comment is precious. But I feel a necessity to analyze > > hfsplus driver code more deeply for proper fix of this issue. An > > userspace-mappable page content is the main use-case for such fix. But > > it exists the multi CPUs use-case. So, I need to think about correctness > > of hfsplus driver for such use-case also, I think. > > > > > > > > btw, I still have question marks over your earlier patches: > > > > > > hfsplus-add-on-disk-layout-declarations-related-to-attributes-tree.patch > > > hfsplus-add-functionality-of-manipulating-by-records-in-attributes-tree.patch > > > hfsplus-rework-functionality-of-getting-setting-and-deleting-of-extended-attributes.patch > > > hfsplus-add-support-of-manipulation-by-attributes-file.patch > > > hfsplus-add-support-of-manipulation-by-attributes-file-checkpatch-fixes.patch > > > hfsplus-code-style-fixes-reworked-support-of-extended-attributes.patch > > > > > > Christoph sounded unhappy, but the review discussion petered out? > > > > > > > So, as you can see the discussion revives again. :-) And I need to > > familiarize with implementation of xattrs in JFS before to answer again. > > I had objection that we need to remember about using HFS+ volumes as > > under Linux as under Mac OS X. Maybe, JFS implementation of xattrs to > > change my vision. > > I'm still unclear where we stand with these patches. Which if any of > these should I merge? > As I can see these patches contain implementation of xattr support (v3) and reworked error processing in some parts of hfsplus driver. The version 3 of xattr support was implemented after remarks of Christoph Hellwig about necessity to have "osx." prefix. So, after this e-mail we had achieved understanding about proper implementation and it was done. Maybe I misunderstand something but I thought that these patches were merged in linux-next yet. Or do you talking about merging in mainline? Currently, I am working on ACLs support in hfsplus driver. But, from my point of view, these patches are important and without ACLs support. With the best regards, Vyacheslav Dubeyko. > Thanks. > > hfsplus-avoid-crash-on-failed-block-map-free.patch > http://ozlabs.org/~akpm/mmots/broken-out/hfsplus-avoid-crash-on-failed-block-map-free.patch > > hfsplus-add-osx-prefix-for-handling-namespace-of-mac-os-x-extended-attributes.patch > http://ozlabs.org/~akpm/mmots/broken-out/hfsplus-add-osx-prefix-for-handling-namespace-of-mac-os-x-extended-attributes.patch > > hfsplus-add-on-disk-layout-declarations-related-to-attributes-tree.patch > http://ozlabs.org/~akpm/mmots/broken-out/hfsplus-add-on-disk-layout-declarations-related-to-attributes-tree.patch > > hfsplus-add-functionality-of-manipulating-by-records-in-attributes-tree.patch > http://ozlabs.org/~akpm/mmots/broken-out/hfsplus-add-functionality-of-manipulating-by-records-in-attributes-tree.patch > > hfsplus-rework-functionality-of-getting-setting-and-deleting-of-extended-attributes.patch > http://ozlabs.org/~akpm/mmots/broken-out/hfsplus-rework-functionality-of-getting-setting-and-deleting-of-extended-attributes.patch > > hfsplus-add-support-of-manipulation-by-attributes-file.patch > http://ozlabs.org/~akpm/mmots/broken-out/hfsplus-add-support-of-manipulation-by-attributes-file.patch > > hfsplus-rework-processing-errors-in-hfsplus_free_extents.patch > http://ozlabs.org/~akpm/mmots/broken-out/hfsplus-rework-processing-errors-in-hfsplus_free_extents.patch > > hfsplus-rework-processing-of-hfs_btree_write-returned-error.patch > http://ozlabs.org/~akpm/mmots/broken-out/hfsplus-rework-processing-of-hfs_btree_write-returned-error.patch > > hfsplus-add-error-message-for-the-case-of-failure-of-sync-fs-in-delayed_sync_fs-method.patch > http://ozlabs.org/~akpm/mmots/broken-out/hfsplus-add-error-message-for-the-case-of-failure-of-sync-fs-in-delayed_sync_fs-method.patch > -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
