The if (!pcol->read_4_write) at the error path is redundant because all goto err; are after the if (pcol->read_4_write) bale out. Signed-off-by: Boaz Harrosh <bharrosh@xxxxxxxxxxx> --- fs/exofs/inode.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/exofs/inode.c b/fs/exofs/inode.c index 87f05d9..449da05 100644 --- a/fs/exofs/inode.c +++ b/fs/exofs/inode.c @@ -364,9 +364,7 @@ err: if (!pcol_copy) /* Failed before ownership transfer */ pcol_copy = pcol; - if (!pcol->read_4_write) - _unlock_pcol_pages(pcol_copy, ret, READ); - + _unlock_pcol_pages(pcol_copy, ret, READ); pcol_free(pcol_copy); kfree(pcol_copy); return ret; -- 1.7.10.2.677.gb6bc67f -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
