On 11/30/2012 04:10 PM, Boaz Harrosh wrote: > On 11/26/2012 04:49 PM, Idan Kedar wrote: >> if ore_write() fails, we would unlock the pages of pcol, which is now >> empty, rather than pcol_copy which owns the pages when ore_write() is >> called. this means that no pages will actually be unlocked >> (pcol.nr_pages == 0) and the writing process (more accurately, the >> syncing process) will hang waiting for a writeback notification that >> never comes. >> >> moreover, if ore_write() fails, pcol_free() is called for pcol, whereas >> pcol_copy is the object owning the ore_io_state, thus leaking the >> ore_io_state. >> >> Signed-off-by: Idan Kedar <idank@xxxxxxxxxx> > > Thanks Idan, good catch. > > I have simplified your patch a bit, see below. But basically it > is all the same. Please check me out > I forgot to ask do you need this for stable? Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
