Re: [PATCH] hfsplus: rework processing of return value of bio_alloc() in hfsplus_submit_bio()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2012-11-28 at 08:22 -0500, Christoph Hellwig wrote:
> On Wed, Nov 28, 2012 at 05:18:19PM +0400, Vyacheslav Dubeyko wrote:
> > I don't insist on the patch. But if the function has such description:
> > 
> >  *   RETURNS:
> >  *   Pointer to new bio on success, NULL on failure.
> > 
> > I prefer to check on NULL anyway. :-)
> 
> 
> Check the sentence a couple lines above in the same comment:
> 
>  *   When @bs is not NULL, if %__GFP_WAIT is set then bio_alloc will always be
>  *   able to allocate a bio. This is due to the mempool guarantees.
> 

Ok. Agree. Thank you. :-)

With the best regards,
Vyacheslav Dubeyko.


--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux