On Wed, 2012-11-28 at 07:48 -0500, Christoph Hellwig wrote: > On Wed, Nov 28, 2012 at 01:27:34PM +0400, Vyacheslav Dubeyko wrote: > > Hi, > > > > This patch adds logic of checking return value of bio_alloc() in hfsplus_submit_bio(). In the case of NULL the hfsplus_submit_bio() returns -EIO. > > bio_alloc does a mempool allocation and thus will never return NULL. > I don't insist on the patch. But if the function has such description: * RETURNS: * Pointer to new bio on success, NULL on failure. I prefer to check on NULL anyway. :-) With the best regards, Vyacheslav Dubeyko. > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
