On Mon, Nov 12, 2012 at 11:40:01PM -0800, Andrew Morton wrote: > On Tue, 13 Nov 2012 11:20:57 +0400 Cyrill Gorcunov <gorcunov@xxxxxxxxxx> wrote: > > > > > > Whoa. This adds 128+8 bytes to the inotify_inode_mark. That's a lot of > > > bloat, and there can be a lot of inotify_inode_mark's in the system? > > > > Yes, that's why it's not turned on by default, only if is c/r turned on. > > iirc I've been said that usually only about 40 bytes is used (in the tests > > I met only 8 bytes). Letme re-check all things. > > The question is, how many `struct inotify_inode_mark's are instantiated > system-wide? Could be millions? Well, hard to tell, to be fair. On my testing machine only apache has been using inotify system as far as I remember, but for sure nothing except memory limit the number of inotify. But I think if one running machine with millions of inotify it's rather powerful machine with enough memory. > Dumb question: do we really need inotify_inode_mark.fhandle at all? > What prevents us from assembling this info on demand when ->show_fdinfo() is > called? exportfs requires the dentry to be passed as an argument while inotify works with inodes instead and at moment of show-fdinfo the target dentry might be already deleted but inode yet present as far as I remember. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
