On Mon 12-11-12 16:42:43, Dave Chinner wrote: > On Thu, Nov 08, 2012 at 01:41:37PM +0100, Jan Kara wrote: > > When user asks for O_NONBLOCK behavior for a file descriptor, return > > EAGAIN instead of blocking on a frozen filesystem. > > > > Signed-off-by: Jan Kara <jack@xxxxxxx> > > --- > > fs/btrfs/file.c | 3 ++- > > fs/cifs/file.c | 3 ++- > > fs/fuse/file.c | 3 ++- > > fs/ntfs/file.c | 3 ++- > > fs/ocfs2/file.c | 3 ++- > > fs/xfs/xfs_file.c | 3 ++- > > include/linux/fs.h | 10 ++++++++++ > > mm/filemap.c | 3 ++- > > 8 files changed, 24 insertions(+), 7 deletions(-) > > Looks good, though you missed generic_file_splice_write(). Shouldn't > this also return EAGAIN? Yes, it should. Thanks for spotting this. I've also noticed ocfs2 misses freeze protection in splice_write at all. I'll fix that in a separate patch and send v3. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
